New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hospital line + fix bugs & lint issues #259
Conversation
Stylistic feedback:
Overall looks good, and in the interests of moving fast I'll approve this and you can merge, and then you can add the changes in another PR. |
@lagerros I added two points to the PR description that I want your thoughts on. With regard to your points:
|
Looks good! Followup and confusion explanation #264 . Re separation of the line: I personally think it's actually better, but because I simply think about this as a part of the chart/traces, which may be different from the user 🤷♂️ . Nevertheless, it's surely possible to add custom text at the chart via annotations. |
Fixes #226 by using preliminary hospital bed data from here
Once #125 / #258 is completed, the code will need slight updates to incorporate the new data, but it won't break in the meantime.
There are a couple of things I didn't do that might be an issue though:
beds_p_100k
was equivalent to "unused critical care capacity" rather than "total critical care capacity". If it's the latter, that's a problem. We need the former in order for the charts not to be deceptive.This PR also fixes an inefficient double-rendering upon page load and a number of smaller lint issues with the JavaScript.