New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand model description. #373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I added a few comments but no real errors or issues.
This now also has the backcalculation model so would benefit from another round of review. |
Will do tomorrow. |
This is a nice way of describing this. |
Nothing to see sadly (even before I accidentally edited your comment to remove the invisible screenshot). |
The change to have the log difference on the LHS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice. I made some changes and pulled out the GP details section into its own vignette (as may be shared between models etc). The biggest change is changing the name of the non-parametric model -> non-mechanistic because non-parametric models are a dream of AI bros.
I've pushed 1.3.5
into its own branch in case it gets bounced by CRAN (so we can update main
). I'll leave this with you to merge as you wish/once you've made any changes you would like to.
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 555debd is merged into main:
|
(going to merge and we can iterate) |
An attempt to make the model description self-contained, i.e. allow others to re-implement the full model (almost) completely.