Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style change in response to lintr warnings #437

Merged
merged 7 commits into from Jul 25, 2023
Merged

style change in response to lintr warnings #437

merged 7 commits into from Jul 25, 2023

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Jul 24, 2023

With the recent update to lintr we are seeing a few new warnings. This fixes them.

sbfnk added a commit that referenced this pull request Jul 24, 2023
These were meant to happen in #437.
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you just expand a bit on why the cat call is needed?

R/estimate_truncation.R Outdated Show resolved Hide resolved
@sbfnk
Copy link
Contributor Author

sbfnk commented Jul 25, 2023

Could you just expand a bit on why the cat call is needed?

It is not. I've removed it.

@seabbs seabbs self-requested a review July 25, 2023 13:04
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@sbfnk sbfnk merged commit 0b7167f into main Jul 25, 2023
9 checks passed
@seabbs seabbs deleted the linting branch July 25, 2023 20:39
sbfnk added a commit that referenced this pull request May 3, 2024
These were meant to happen in #437.
sbfnk added a commit that referenced this pull request May 3, 2024
* style change in response to lintr warnings

* update news

* bump version

* Update DESCRIPTION

* Update NEWS.md

* remove stray message

---------

Co-authored-by: Sam Abbott <s.e.abbott12@gmail.com>
sbfnk added a commit that referenced this pull request May 3, 2024
These were meant to happen in #437.
sbfnk added a commit that referenced this pull request May 3, 2024
* style change in response to lintr warnings

* update news

* bump version

* Update DESCRIPTION

* Update NEWS.md

* remove stray message

---------

Co-authored-by: Sam Abbott <s.e.abbott12@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants