Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update phi parameterisation #487

Merged
merged 12 commits into from Oct 25, 2023
Merged

Update phi parameterisation #487

merged 12 commits into from Oct 25, 2023

Conversation

seabbs
Copy link
Contributor

@seabbs seabbs commented Oct 25, 2023

renamed PR closing #485

seabbs and others added 12 commits October 24, 2023 17:25
@seabbs
Update observation_model.stan
85d5563
@seabbs
Update NEWS.md
daf7e5d
@seabbs @sbfnk
Update inst/stan/functions/observation_model.stan
7b99861 
Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>
@seabbs @sbfnk
Update inst/stan/functions/observation_model.stan
38a520a 
Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>
@seabbs @sbfnk
Update inst/stan/functions/observation_model.stan
bb5f8aa 
Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>
@seabbs @sbfnk
Update inst/stan/functions/observation_model.stan
e63595b 
Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>
@seabbs @sbfnk
Update inst/stan/functions/observation_model.stan
6e1e54b 
Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>
@seabbs @sbfnk
Update inst/stan/functions/observation_model.stan
9505d04 
Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>
@seabbs @sbfnk
Update inst/stan/functions/observation_model.stan
66808b8 
Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>
@seabbs
sqrt_phi -> dispersion
c64d812
@seabbs
Catch another sqrt_phi
62b5b8e
@seabbs @sbfnk
Update NEWS.md
e02e300 
Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>
@seabbs seabbs mentioned this pull request Oct 25, 2023
Closed
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 9767461 is merged into main:

  •   :ballot_box_with_check:default: 46.9s -> 48.9s [-13.53%, +21.94%]
  •   :ballot_box_with_check:no_delays: 47.7s -> 47.7s [-9.15%, +9.18%]
  •   :ballot_box_with_check:random_walk: 14.5s -> 14.1s [-10.12%, +4.3%]
  •   :ballot_box_with_check:stationary: 27.4s -> 29.3s [-3.82%, +17.44%]
  •   :ballot_box_with_check:uncertain: 1.12m -> 1.11m [-23.2%, +21.31%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@seabbs
Copy link
Contributor Author

seabbs commented Oct 25, 2023

No change in speed but then I would really expect the change to be 1. very small and 2. only show up when the data needs stabilising

@seabbs seabbs requested a review from sbfnk October 25, 2023 12:34
@seabbs seabbs merged commit 2cc568e into main Oct 25, 2023
20 checks passed
@seabbs seabbs deleted the update-phi-parameterisation branch October 25, 2023 13:22
@seabbs seabbs mentioned this pull request Oct 26, 2023
Closed
@jamesmbaazam jamesmbaazam mentioned this pull request Oct 27, 2023
Closed
sbfnk added a commit that referenced this pull request May 3, 2024
@seabbs @sbfnk
Update phi parameterisation (#487)
82ce808 
* Update observation_model.stan

* Update NEWS.md

* Update inst/stan/functions/observation_model.stan

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

* Update inst/stan/functions/observation_model.stan

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

* Update inst/stan/functions/observation_model.stan

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

* Update inst/stan/functions/observation_model.stan

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

* Update inst/stan/functions/observation_model.stan

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

* Update inst/stan/functions/observation_model.stan

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

* Update inst/stan/functions/observation_model.stan

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

* sqrt_phi -> dispersion

* Catch another sqrt_phi

* Update NEWS.md

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

---------

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>
sbfnk added a commit that referenced this pull request May 3, 2024
@seabbs @sbfnk
Update phi parameterisation (#487)
923051c 
* Update observation_model.stan

* Update NEWS.md

* Update inst/stan/functions/observation_model.stan

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

* Update inst/stan/functions/observation_model.stan

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

* Update inst/stan/functions/observation_model.stan

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

* Update inst/stan/functions/observation_model.stan

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

* Update inst/stan/functions/observation_model.stan

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

* Update inst/stan/functions/observation_model.stan

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

* Update inst/stan/functions/observation_model.stan

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

* sqrt_phi -> dispersion

* Catch another sqrt_phi

* Update NEWS.md

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>

---------

Co-authored-by: Sebastian Funk <sebastian.funk@lshtm.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbfnk sbfnk sbfnk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seabbs @sbfnk