Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate report_cases, sample_approx_dist and adjust_infection_report #520

Closed
sbfnk opened this issue Nov 21, 2023 · 2 comments · Fixed by #597
Closed

Deprecate report_cases, sample_approx_dist and adjust_infection_report #520

sbfnk opened this issue Nov 21, 2023 · 2 comments · Fixed by #597
Assignees
@jamesmbaazam

Comments

@sbfnk
Copy link
Contributor

sbfnk commented Nov 21, 2023 

          As part of this we could probably deprecate `sample_approx_dist` and `adjust_infection_report`, and replace `dist_skel` with a simpler version that just calculates the pmf in line with #411

Originally posted by @sbfnk in #504 (comment)
@sbfnk
Copy link
Contributor Author

sbfnk commented Nov 21, 2023

All the relevant functionality there could be done using the simulate_secondary model.

@seabbs
Copy link
Contributor

seabbs commented Nov 28, 2023

yup good idea

This was referenced Feb 20, 2024
Closed
Merged
@jamesmbaazam jamesmbaazam self-assigned this Mar 4, 2024
@jamesmbaazam jamesmbaazam mentioned this issue Mar 4, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesmbaazam jamesmbaazam

Labels
None yet
Projects
EpiNow2 v1.5.0
Status: Done
Milestone
No milestone
3 participants
@sbfnk @seabbs @jamesmbaazam