Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fixed observation scaling #550

Merged
merged 8 commits into from Feb 19, 2024
Merged

Enable fixed observation scaling #550

merged 8 commits into from Feb 19, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Feb 14, 2024

Closes Partially addresses #549

Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if df1fdc8 is merged into main:

  •   :ballot_box_with_check:default: 32.3s -> 31.2s [-24.49%, +17.55%]
  •   :ballot_box_with_check:no_delays: 32.4s -> 32.7s [-14.75%, +16.89%]
  •   :ballot_box_with_check:random_walk: 9.11s -> 9.84s [-3.11%, +18.96%]
  •   :ballot_box_with_check:stationary: 18.6s -> 18.7s [-12.71%, +14.39%]
  •   :ballot_box_with_check:uncertain: 50.8s -> 1.08m [-52.78%, +109.23%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 50fc3cf is merged into main:

  • ❗🐌default: 28.8s -> 33.6s [+5.27%, +27.8%]
  •   :ballot_box_with_check:no_delays: 34.6s -> 33.2s [-20.04%, +11.81%]
  •   :ballot_box_with_check:random_walk: 9.39s -> 9.13s [-14.02%, +8.62%]
  •   :ballot_box_with_check:stationary: 18s -> 20.3s [-0.15%, +25.69%]
  •   :ballot_box_with_check:uncertain: 49.9s -> 50.8s [-21.3%, +24.87%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@sbfnk
Copy link
Contributor Author

sbfnk commented Feb 16, 2024

Similar PR for phi to follow

Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 50fc3cf is merged into main:

  •   :ballot_box_with_check:default: 31.4s -> 30.5s [-16.05%, +10%]
  •   :ballot_box_with_check:no_delays: 34.6s -> 36.4s [-8.32%, +18.51%]
  •   :ballot_box_with_check:random_walk: 9.3s -> 9.09s [-8.61%, +4.07%]
  •   :ballot_box_with_check:stationary: 25.9s -> 19.3s [-111.58%, +61.16%]
  •   :ballot_box_with_check:uncertain: 47.6s -> 51.8s [-6.52%, +24.07%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 23229a8 is merged into main:

  • ✔️default: 35.3s -> 32.2s [-28.69%, +11.16%]
  • ✔️no_delays: 33.3s -> 36.5s [-2.13%, +21.73%]
  • 🚀random_walk: 10.1s -> 8.83s [-21.99%, -2.64%]
  • ✔️stationary: 19.9s -> 17.2s [-34.67%, +8.14%]
  • ✔️uncertain: 49.7s -> 51.3s [-10.35%, +16.66%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@seabbs seabbs enabled auto-merge (squash) February 19, 2024 23:03
NEWS.md Outdated Show resolved Hide resolved
seabbs
seabbs previously approved these changes Feb 19, 2024
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seabbs seabbs self-requested a review February 19, 2024 23:07
@seabbs seabbs disabled auto-merge February 19, 2024 23:08
@seabbs seabbs merged commit 8a38ebb into main Feb 19, 2024
10 of 11 checks passed
@seabbs seabbs deleted the fixed-frac-obs branch February 19, 2024 23:08
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 23229a8 is merged into main:

  • ✔️default: 30.9s -> 33.3s [-13.07%, +28.39%]
  • ✔️no_delays: 31.4s -> 33.9s [-8.99%, +25.12%]
  • ✔️random_walk: 8.78s -> 16.8s [-109.14%, +290.69%]
  • ❗🐌stationary: 16.6s -> 18.8s [+4.27%, +21.22%]
  • ✔️uncertain: 48.9s -> 52.3s [-6.02%, +19.73%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

sbfnk added a commit that referenced this pull request May 3, 2024
* allow fixed fraction observed

* add test

* update existing tests

* make indentation consistent

* add news item

* improve documentation of scale parameter

* add PR number

* Update NEWS.md

---------

Co-authored-by: Sam Abbott <s.e.abbott12@gmail.com>
sbfnk added a commit that referenced this pull request May 3, 2024
* allow fixed fraction observed

* add test

* update existing tests

* make indentation consistent

* add news item

* improve documentation of scale parameter

* add PR number

* Update NEWS.md

---------

Co-authored-by: Sam Abbott <s.e.abbott12@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants