Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulate secondary #591

Merged
merged 10 commits into from Mar 4, 2024
Merged

Simulate secondary #591

merged 10 commits into from Mar 4, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Mar 1, 2024

Description

This PR closes #563 by introducing a new function simulate_secondary(). The existing function of that named has been renamed to convolve_and_scale()

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@sbfnk sbfnk enabled auto-merge (squash) March 1, 2024 16:45
Copy link
Contributor

github-actions bot commented Mar 1, 2024

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 97e07cf is merged into main:

  • ✔️default: 33s -> 33.3s [-11.71%, +13.89%]
  • ✔️no_delays: 46.4s -> 34.6s [-85.18%, +34.25%]
  • ✔️random_walk: 9.59s -> 9.14s [-18.24%, +9.01%]
  • ✔️stationary: 21.5s -> 17.7s [-55.23%, +20.47%]
  • ✔️uncertain: 50.5s -> 1.03m [-18.71%, +63.44%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

seabbs
seabbs previously approved these changes Mar 1, 2024
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A bit of a painful merge I think.

NEWS.md Outdated Show resolved Hide resolved
R/simulate_secondary.R Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Mar 1, 2024

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8d0f69c is merged into main:

  • ✔️default: 33.3s -> 34.5s [-8.51%, +15.97%]
  • 🚀no_delays: 35.3s -> 31.9s [-15.9%, -3.28%]
  • ✔️random_walk: 9.92s -> 9s [-19.59%, +1.03%]
  • ✔️stationary: 18.6s -> 18.8s [-10.19%, +12.55%]
  • ✔️uncertain: 46.4s -> 50.9s [-10.45%, +30.13%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Contributor

github-actions bot commented Mar 2, 2024

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 65b3043 is merged into main:

  • ✔️default: 31.9s -> 31.8s [-14.22%, +13.62%]
  • ❗🐌no_delays: 31.7s -> 35.6s [+3.92%, +20.88%]
  • ✔️random_walk: 9s -> 9.05s [-7.92%, +9.02%]
  • ✔️stationary: 16.9s -> 21.5s [-11.44%, +65.31%]
  • ✔️uncertain: 51.9s -> 53.6s [-15.34%, +22.07%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@sbfnk
Copy link
Contributor Author

sbfnk commented Mar 4, 2024

All changes since last review were merges / minor doc changes so merging as is.

@sbfnk sbfnk disabled auto-merge March 4, 2024 08:53
@sbfnk sbfnk merged commit f64960c into main Mar 4, 2024
14 checks passed
@sbfnk sbfnk deleted the simulate-secondary branch March 4, 2024 08:53
sbfnk added a commit that referenced this pull request May 3, 2024
* `simulate_secondary()` -> `convolve_and_scale()`

* simulate_secondary function

* add tests

* add news item

* load data.table explicitly in example

* Apply suggestions from code review

Co-authored-by: Sam Abbott <s.e.abbott12@gmail.com>

* add correct documentation

---------

Co-authored-by: Sam Abbott <s.e.abbott12@gmail.com>
sbfnk added a commit that referenced this pull request May 3, 2024
* `simulate_secondary()` -> `convolve_and_scale()`

* simulate_secondary function

* add tests

* add news item

* load data.table explicitly in example

* Apply suggestions from code review

Co-authored-by: Sam Abbott <s.e.abbott12@gmail.com>

* add correct documentation

---------

Co-authored-by: Sam Abbott <s.e.abbott12@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stan model implementation of simulate_secondary
2 participants