New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 1 before fitting final week when creating shifted cases #612
Conversation
f2f86d3
to
fafe2bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. I wonder if this feature should be exposed in the function's documentation?
Thanks, added some detail in 2ab300e and used the opportunity to improve the example and code documentation (with apologies, slightly deviating from the original Issue). |
* fit to x+1 and avoid touching zeroes * add news item * add details * add clearer example * don't use gt for seeding in nonmechanistic model * add reviewer
* fit to x+1 and avoid touching zeroes * add news item * add details * add clearer example * don't use gt for seeding in nonmechanistic model * add reviewer
Description
This PR closes #611
by keeping values constant instead of setting zeroes to 1 (this approach has proven unstable)by adding 1 to the number of confirmed cases before fitting (and subtracting again when using the fit).Initial submission checklist
devtools::test()
anddevtools::check()
).devtools::document()
).lintr::lint_package()
).After the initial Pull Request