Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce arguments across functions #73

Closed
seabbs opened this issue Sep 26, 2020 · 0 comments · Fixed by #74 or #102
Closed

Reduce arguments across functions #73

seabbs opened this issue Sep 26, 2020 · 0 comments · Fixed by #74 or #102

Comments

@seabbs
Copy link
Contributor

seabbs commented Sep 26, 2020

As apart of the next release it might make sense to deal with some of the current argument bloat.

One major contributor to the number of arguments are the stan controls. As stan_args allows any arguments to be passed to stan the number of surfaced arguments could potentially be reduced (i.e removing warmup, chains, adapt delta etc) and reducing these to internal defaults. This would however be a fairly substantial breaking change for any downstream users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant