Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor comments #7

Closed
5 tasks done
kathsherratt opened this issue Mar 31, 2020 · 3 comments
Closed
5 tasks done

Minor comments #7

kathsherratt opened this issue Mar 31, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@kathsherratt
Copy link
Collaborator

kathsherratt commented Mar 31, 2020

Some minor and non-critical comments:

Global summary page:

  • General: use of word “regions” > personal preference is the word “countries” instead as regions sounds more like a group of countries (but only a preference, either works)
  • Figure 1: “Likely Increasing” colour grey > looks a bit too close to NA to me - could change to e.g. light blue - or to a sequential scale so that all three values are in colour order (Increasing > Likely increasing > Unsure)
  • Figure 4: it might be easier to read and compare if ordered by geographic region, but not a problem as is
  • Figure 8: to me the title reads a bit awkwardly and doesn’t intuitively match the caption (which explains really well). Going by the caption, I’d change from “Cases with date of onset on the day of report generation in all regions” to “Cases by date of report, and estimated cases by date of infection”

Methods page:

  • Typo in header caption: “publically” > “publicly” available data
@samclifford samclifford mentioned this issue Apr 1, 2020
6 tasks
@seabbs seabbs added the enhancement New feature or request label Apr 1, 2020
@seabbs
Copy link
Contributor

seabbs commented Apr 1, 2020

All sounds good - light edit to add tick boxes

@seabbs seabbs mentioned this issue Apr 1, 2020
2 tasks
@seabbs
Copy link
Contributor

seabbs commented Apr 1, 2020

Had a go at fixing figure 8 title - let me know what you think?

Think reordering by geography might be a bit of a mission. If keen on this please add to medium term changes as could be a good idea.

Region over country: Everything is built from templates so this is also pretty tricky. Could be a good idea though so please add to medium term issues :)

@seabbs
Copy link
Contributor

seabbs commented Apr 2, 2020

Closed as resolved or categorized for future work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants