Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional tests #307

Closed
wants to merge 2 commits into from
Closed

Additional tests #307

wants to merge 2 commits into from

Conversation

joseph-palmer
Copy link
Collaborator

WIP

This Branch acts as a place to merge PRs for additional tests (listed in #302). If you are working on a test please write your name next to it on the checklist with the pr number for it.

To get started I have added tests that region names are not all NA.

closes #302

@github-actions
Copy link

github-actions bot commented Apr 23, 2021

👋 Thanks for opening this pull request! Can you please run through the following checklist before requesting review (ticking as complete or if not relevant).

  • Read our contribution guidelines if you have not already done so.
  • If you have altered an existing class please run the tests locally (using devtools::load_all(); devtools::test()) first setting options(testDownload=TRUE, testSource=class-name) and report your findings.
  • If you have added a new data class please run the tests locally for that class (using devtools::load_all(); devtools::test()).
  • Check your code passes our CI checks and review any style and code coverage warnings.
  • Comment with details if unable to get our CI checks to pass or unable to remove all warnings.

Thank you again for the contribution. If making large scale changes consider using our pre-commit hooks (see the contributing guide) to more easily comply with our guidelines.

@seabbs
Copy link
Contributor

seabbs commented Jun 4, 2021

I imagine this has some conflicts with recent package changes? Should we pause on this for now and or pull the code out elsewhere? It might be worth having a little think about data integrity checks in general (i.e a validate check of a data source separate from "unit" testing etc). It would be nice to increase data specific testing. Same goes for #312.

@github-actions
Copy link

github-actions bot commented Aug 4, 2021

This PR has been flagged as stale due to lack of activity

@seabbs seabbs closed this Feb 4, 2022
@seabbs seabbs deleted the additional_tests branch February 5, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional tests for get_regional_data
2 participants