Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking IDate, Adding CmdStan Requirements, CmdStanR argument completion #26

Merged
merged 7 commits into from Jan 29, 2022

Conversation

medewitt
Copy link
Collaborator

This PR resolves

  • an esoteric bug where some of the pre-processing code expects a class of IDate and when presenting with a Date class fails oddly.
  • Adds the system requirement for CmdStan
  • Bumps version to dev
  • Uses full argument name for one of the the CmdStanR functions (include_paths) to clear console of argument completion warning
  • Updated NEWS

@seabbs
Copy link
Collaborator

seabbs commented Jan 21, 2022

Thanks for this @medewitt this looks good. Just flagging that I have seen this, appreciate it, and will look at it in more detail at the earliest opportunity. Pretty slammed with Omicron related work at the moment so this is having to take a back seat.

@seabbs seabbs self-requested a review January 21, 2022 11:16
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #26 (957f9bd) into main (2ec15a9) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 957f9bd differs from pull request most recent head 1b22d9f. Consider uploading reports for the commit 1b22d9f to get more accurate results
Impacted file tree graph

@@          Coverage Diff          @@
##            main     #26   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         13      13           
  Lines        638     642    +4     
=====================================
- Misses       638     642    +4     
Impacted Files Coverage Δ
R/model.R 0.00% <0.00%> (ø)
R/preprocess.R 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ec15a9...1b22d9f. Read the comment docs.

Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @medewitt! I just fixed a few spacing issues. Would you like to submit another PR with your contributor details?

@seabbs seabbs merged commit 272976c into epinowcast:main Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants