Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code coverage #686

Open
nikosbosse opened this issue Mar 6, 2024 · 2 comments
Open

Improve code coverage #686

nikosbosse opened this issue Mar 6, 2024 · 2 comments

Comments

@nikosbosse
Copy link
Contributor

nikosbosse commented Mar 6, 2024

We should aim to increase our code coverage and bring it back up.

Specifically, we should double-check the codecov report from #583 - codecov complained that a few lines were not covered even though I think they are. Update: done in #703 and #704

@seabbs
Copy link
Contributor

seabbs commented Mar 7, 2024

Specifically, we should double-check the codecov report from #583 - codecov complained that a few lines were not covered even though I think they are.

If that is the case are you thinking there is a bug in code coverage, a bug in how our coverage is being collected, or a bug in our test setup (so not everything is called). I think this might warrant a further issue as its separate from the low coverage problems imo

@nikosbosse
Copy link
Contributor Author

If that is the case are you thinking there is a bug in code coverage, a bug in how our coverage is being collected, or a bug in our test setup (so not everything is called). I think this might warrant a further issue as its separate from the low coverage problems IMO

Against all odds, this error might be rooted in human error.. 🙈 Discussed in #703 and fixed in #704.

@nikosbosse nikosbosse added this to the scoringutils-2.x milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants