Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and reorganise files #746

Open
7 tasks
Tracked by #749
nikosbosse opened this issue Mar 24, 2024 · 4 comments
Open
7 tasks
Tracked by #749

Rename and reorganise files #746

nikosbosse opened this issue Mar 24, 2024 · 4 comments

Comments

@nikosbosse
Copy link
Contributor

nikosbosse commented Mar 24, 2024

  • convencience-functions.R should be renamed to transform_forecasts.R
  • set_forecast_unit() should be moved to a file get_forecast_unit.R (maybe forecast_unit.R?) together with get_forecast_unit().
  • correlations.R should be get_correlations.R
  • different get_-functions should be moved out of get_-functions.R
  • metrics-range.R --> metrics-interval_range.R
  • customise_metric() should maybe get its own file. Alternatively, the corresponding tests should be moved.
  • the current function validate_scores should really be assert_scores()
@seabbs
Copy link
Contributor

seabbs commented Apr 12, 2024

Is this all done now?

@nikosbosse
Copy link
Contributor Author

We did another set of renaming/restructuring files previously, this one is still open.

@sbfnk
Copy link
Contributor

sbfnk commented Apr 19, 2024

get_-functions.R also contains some assert_... and test_... functions which I think should be moved to one of the check-....R fiiles.

@jamesmbaazam
Copy link
Contributor

jamesmbaazam commented Apr 19, 2024

@nikosbosse You could perhaps do this as a final step before release since it's not a functional change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

4 participants