New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider capping heatmaps #15

Closed

2 tasks

sreichl opened this issue Mar 4, 2024 · 1 comment

Assignees

Contributor

sreichl commented Mar 4, 2024 •

edited

Get input from the team.
cap heatmaps like in enrichment analysis e.g.,
- simple cap ie LFC>cap_th -> set to cap_th
- log? (log again the LFC?)
- scale the heatmaps?

Consider: it is a breaking change as it requires a new config field...

sreichl self-assigned this

sreichl mentioned this issue

consider capping heatmaps epigen/dea_limma#11

Closed

2 tasks

Contributor Author

sreichl commented Apr 5, 2024

decision: no capping. reasons below.

capping of LFC per default is misleading.
Can be easily done manually by the user downstream if desired.
log of LFC doesn't make sense.
breaking change for not-requested feature

sreichl closed this as not planned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment