Match more liberally on URL segments #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Items only match if the search string prefix-matches a word in the `match` property. This can be inconvenient for, say, a tab where Spotify is playing. We want to type "spotify" and have the tab match, but the `match` property looks like "Song Name . Artist open.spotify.com/user/<username>". Hence, we'll get a match if we type "open.spotify", but not if we type "spotify". This change splits `matchUrl` into many elements for more liberal keyword matching. Tabs will now match any subdomain, the root domain, or any element of the path or query.
|
🚀 This has been released with v1.0.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Items only match if the search string a word in the
matchproperty from the start. This can be inconvenient, for example when we want to open a tab where Spotify is playing. When playing, the tab title doesn't include the word "Spotify".Ideally, we could type "spotify" and have the tab match, but the
matchproperty looks likeSong Name . Artist open.spotify.com/user/<username>. We'll get a match if we type "open.spotify", but not if we type "spotify".This change splits
matchUrlinto many elements for more liberal keyword matching. Tabs will now match any subdomain, the root domain, or any element of the path or query.With this change, the tab from the previous scenario would have a
matchproperty ofSong Name . Artist open spotify com user <username>. Since this includes the word "spotify", it will match our search string.Absolutely no offence taken if this is not behaviour you want! Just offering the patch in case you like it.