Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Facebook Login #126

Merged
merged 6 commits into from Dec 9, 2019
Merged

Add Facebook Login #126

merged 6 commits into from Dec 9, 2019

Conversation

nerdogram
Copy link
Contributor

WHAT?!

Added Facebook login in Social media logins.

@nerdogram nerdogram mentioned this pull request Dec 5, 2019
Closed
epilande
epilande requested changes Dec 5, 2019
View reviewed changes
Copy link
Owner

@epilande epilande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alvisanovari overall looks really good!

Once the requested changes are made, we can merge this!

gatsby-theme-firebase/src/components/SocialLogins.tsx Show resolved Hide resolved
gatsby-theme-firebase/src/components/icons/Facebook.tsx Outdated Show resolved Hide resolved
gatsby-theme-firebase/src/components/icons/Facebook.tsx Outdated Show resolved Hide resolved
gatsby-theme-firebase/src/components/icons/Facebook.tsx Outdated Show resolved Hide resolved
demo/gatsby-config.js Outdated Show resolved Hide resolved
@nerdogram
Copy link
Contributor Author

nerdogram commented Dec 6, 2019 •
edited

Thanks for the feedback! Made the changes.

epilande
epilande approved these changes Dec 9, 2019
View reviewed changes
Copy link
Owner

@epilande epilande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks!

@epilande epilande merged commit dcabada into epilande:master Dec 9, 2019
@epilande epilande mentioned this pull request May 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epilande epilande epilande approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nerdogram @epilande