Fix clippy lints #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epilys
approved these changes
Jan 3, 2022
epilys
requested changes
Jan 3, 2022
joseluis
force-pushed
the
fix-clippy-lints
branch
from
7f25643
to
762032a
Compare
|
Thanks so much!!! I merged the PR manually, because I wanted to edit the dead_code commit without making you go through the trouble of re-pushing yourself since you already did one round of changes. The current HEAD is at 8e0c325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've fixed the clippy warnings for the library (there were a lot of 'em), with a separate commit for each lint, in order to facilitate review and picking & choosing.
In case you want more information on a specific lint you can check the clippy website, e.g.: https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool