Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP buildpack became more clever. Simplify the sample app #1421

Merged
merged 10 commits into from
May 6, 2022

Conversation

jimmykarily
Copy link
Contributor

Signed-off-by: Dimitris Karakasilis DKarakasilis@suse.com

Signed-off-by: Dimitris Karakasilis <DKarakasilis@suse.com>
@jimmykarily jimmykarily requested a review from a team as a code owner May 4, 2022 08:43
enrichman
enrichman previously approved these changes May 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2022

Codecov Report

Merging #1421 (69a2b87) into main (4cdb52e) will decrease coverage by 13.23%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1421       +/-   ##
===========================================
- Coverage   40.43%   27.20%   -13.24%     
===========================================
  Files         155      155               
  Lines       11294    11294               
===========================================
- Hits         4567     3072     -1495     
- Misses       6128     7763     +1635     
+ Partials      599      459      -140     
Flag Coverage Δ
acceptance-api ?
acceptance-apps 25.10% <ø> (+0.11%) ⬆️
acceptance-cli ?
unittests 7.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/api/v1/appchart/match.go 0.00% <0.00%> (-80.65%) ⬇️
internal/api/v1/namespace/match.go 0.00% <0.00%> (-80.65%) ⬇️
internal/api/v1/configurationbinding/create.go 0.00% <0.00%> (-76.64%) ⬇️
internal/api/v1/configurationbinding/delete.go 0.00% <0.00%> (-75.00%) ⬇️
internal/services/instances.go 5.55% <0.00%> (-72.23%) ⬇️
internal/api/v1/service/delete.go 0.00% <0.00%> (-72.00%) ⬇️
internal/api/v1/application/show.go 0.00% <0.00%> (-71.43%) ⬇️
internal/api/v1/service/controller.go 0.00% <0.00%> (-70.00%) ⬇️
internal/api/v1/application/exec.go 0.00% <0.00%> (-69.74%) ⬇️
internal/services/catalog.go 0.00% <0.00%> (-68.09%) ⬇️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cdb52e...69a2b87. Read the comment docs.

@juadk
Copy link
Contributor

juadk commented May 4, 2022

Next thing is to fix https://github.com/epinio/example-wordpress (removing buildpack.yml etc)

juadk added a commit to epinio/example-wordpress that referenced this pull request May 5, 2022
@jimmykarily jimmykarily merged commit c79a332 into main May 6, 2022
@jimmykarily jimmykarily deleted the fix_php_sample_app branch May 6, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants