Bind namespace #1425
Merged
Bind namespace #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1425 +/- ##
========================================
- Coverage 8.50% 8.44% -0.06%
========================================
Files 78 78
Lines 7444 7492 +48
========================================
Hits 633 633
- Misses 6773 6821 +48
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
enrichman
force-pushed
the
spike-authz-epinio
branch
from
739c74d
to
b4d7c95
Compare
1 task
jimmykarily
reviewed
May 10, 2022
| }) | ||
| }) | ||
|
|
||
| When("user2 try to show a namespace", func() { |
There was a problem hiding this comment.
I think user1 and user2 are symmetric in this test, we don't need to test them both. There is nothing special about user1 compared to user2.
Co-authored-by: Dimitris Karakasilis <jimmykarily@gmail.com>
jimmykarily
previously approved these changes
May 10, 2022
andreas-kupries
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref:
This PR will handle namespaces authorization with users.
When a User creates a namespace then the namespace will be automatically assigned to him.
When a User deletes a namespace it will be unassigned from ALL the users.