Added error checking for env vars and flags #1875
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed TODO and added error checking for viper environment variables and flags.
related to #1870 and #1859
Suppressing errors is not a good idea. If anything occurs we should be aware of it.
The problem of the
log.Fatal(err)
approach is that it's the only viable option in theinit()
func (that's why I'm not a fan of them). They are used in the Cobra user guide, and that's why this setup is widespread.But this is something that they don't like as well, and I guess that they are more or less working on it: