Added ServiceAccountName to staging job #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 51.95% // Head: 57.98% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2074 +/- ##
==========================================
+ Coverage 51.95% 57.98% +6.03%
==========================================
Files 181 181
Lines 14617 14615 -2
==========================================
+ Hits 7594 8475 +881
+ Misses 6042 5060 -982
- Partials 981 1080 +99
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
enrichman
force-pushed
the
1926-enable-access-to-aws-resources-through-irsa-iam-roles-for-service-accounts
branch
from
8610c19
to
4d16c3a
Compare
small refactor of the staging job func
enrichman
force-pushed
the
1926-enable-access-to-aws-resources-through-irsa-iam-roles-for-service-accounts
branch
from
4d16c3a
to
3e18515
Compare
andreas-kupries
requested changes
Feb 9, 2023
andreas-kupries
approved these changes
Feb 9, 2023
enrichman
deleted the
1926-enable-access-to-aws-resources-through-irsa-iam-roles-for-service-accounts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1926
Needs: epinio/helm-charts#349
This PR adds the STAGING_SERVICE_ACCOUNT_NAME env var to the Epinio server. This variable is provided to the staging job and can be used to set a specific serviceaccount that will be used during the execution.
It also adds a small refactor of the staging job func, reducing a bit the length of the func (this probably needs a better and more complete refactoring but I didn't want to add to much noise to the PR).