Fixed unexpected waiting during async service deployment #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enrichman
force-pushed
the
2288-service-deployment-with-hooks-are-still-waiting
branch
from
2387a51
to
2a156b9
Compare
enrichman
force-pushed
the
2288-service-deployment-with-hooks-are-still-waiting
branch
from
2a156b9
to
8b6d949
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2364 +/- ##
==========================================
- Coverage 65.62% 65.22% -0.40%
==========================================
Files 181 181
Lines 15408 15413 +5
==========================================
- Hits 10111 10053 -58
- Misses 4152 4202 +50
- Partials 1145 1158 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
enrichman
changed the title
enrichman
deleted the
2288-service-deployment-with-hooks-are-still-waiting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2288
This PR fixes the async no-wait deployment of services, using a goroutine that will perform the installation of the service in background, even when it's using Helm hooks that are NOT going to be run asynchronously even when no-wait is specified (see the referenced ticket for more info regarding this behavior).
This mean that we should probably perform a better check of the service status.
In this PR I've also fixed the test that will check immediately the existence of the service if run without the
--wait(because it could take a while before it exists, and before it can be deleted), and added one more test that will not wait if the--waitis specified. In this case the creation should be synchronous, so when the API returns the service should exist.