Fixed mishandling of scheme prefixes in route specifications

[andreas-kupries]

fix #2606

[codecov]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
internal/api/v1/application/create.go	62.93% <70.00%> (+0.25%)	⬆️
internal/api/v1/application/update.go	70.81% <62.50%> (-0.48%)	⬇️

... and 28 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

[mmartin24]

Tested on branch and seems to work:

Before:

➜  epinio git:(main) epinio app update sampleapp --route https://badname.domain.com                      

🚢  Update application
Namespace: workspace
Application: sampleapp
Routes: 
1: https://badname.domain.com

❌  error updating the app: an error occurred while rolling back the release. original upgrade error: failed to create resource: Ingress.extensions "rsampleapp-httpsbadnam-d861250b733bc7690138f948c3029ad4d789031c" is invalid: [spec.rules[0].host: Invalid value: "https:": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*'), spec.tls[0].hosts[0]: Invalid value: "https:": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')]: no Ingress with the name "rsampleapp-sampleapp19-b1f16f232b2c3898f2e814b7545f669f23dad8aa" found

After fix:

• Simple update with https://... works:

➜  epinio git:(2606-route-schema-prefix-fix) epinio app update sampleapp --route https://badname.domain.com

🚢  Update application
Namespace: workspace
Application: sampleapp
Routes: 
1: https://badname.domain.com

• Simple update without https:// still works:

➜  epinio git:(2606-route-schema-prefix-fix) epinio app update sampleapp --route simple-name.domain.com

🚢  Update application
Namespace: workspace
Application: sampleapp
Routes: 
1: simple-name.domain.com

✔️  Successfully updated application

• Update with incorrect https works also:

➜  epinio git:(2606-route-schema-prefix-fix) epinio app update sampleapp --route httpsbad://badname.domain.com

🚢  Update application
Namespace: workspace
Application: sampleapp
Routes: 
1: httpsbad://badname.domain.com

✔️  Successfully updated application

• Update with non- allowed (such as capitals) characters still is prevented:

➜  epinio git:(2606-route-schema-prefix-fix) epinio app update sampleapp --route httpsbad://BADNAME.domain.com

🚢  Update application
Namespace: workspace
Application: sampleapp
Routes: 
1: httpsbad://BADNAME.domain.com

❌  error updating the app: an error occurred while rolling back the release. original upgrade error: failed to create resource: Ingress.extensions "rsampleapp-domaincom-6f78cc0bd051685a46e7be9a10c54ad289757840" is invalid: [spec.rules[0].host: Invalid value: "BADNAME.domain.com": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*'), spec.tls[0].hosts[0]: Invalid value: "BADNAME.domain.com": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')]: no Ingress with the name "rsampleapp-badnamedoma-356aa62d0bbb324d80293cef143b71c095548eb5" found

[enrichman]

I'm not completely confident about not checking errors.

[mmartin24]

Rechecked in v1.11.0-rc1 and working