Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed incorrect Traefik annotations in LetsEncrypt cluster issuers #2627

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

andreas-kupries
Copy link
Contributor

@andreas-kupries andreas-kupries added the kind/bug Something isn't working label Oct 5, 2023
@andreas-kupries andreas-kupries added this to the v1.11.0 milestone Oct 5, 2023
@andreas-kupries andreas-kupries self-assigned this Oct 5, 2023
@andreas-kupries andreas-kupries changed the title (chart) Fixed bad traefik annotations in LE cluster issuers (chart) Removed incorrect traefik annotations in LE cluster issuers Oct 5, 2023
@andreas-kupries andreas-kupries changed the title (chart) Removed incorrect traefik annotations in LE cluster issuers [helm chart] Removed incorrect traefik annotations in LE cluster issuers Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

see 12 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@andreas-kupries andreas-kupries marked this pull request as ready for review October 5, 2023 11:10
@andreas-kupries andreas-kupries requested a review from a team as a code owner October 5, 2023 11:10
Copy link
Contributor

@thehejik thehejik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested within epinio/helm-charts#499

@andreas-kupries andreas-kupries merged commit 828ff3b into main Oct 9, 2023
16 checks passed
@andreas-kupries andreas-kupries deleted the hc482-cluster-issuer-ingress branch October 9, 2023 11:48
@thehejik
Copy link
Contributor

Verified fixed on GKE with epinio v1.11.0-rc1 with letsencrypt-staging and traefik ingress controller. App deployment also ok.
image

@enrichman enrichman changed the title [helm chart] Removed incorrect traefik annotations in LE cluster issuers Removed incorrect Traefik annotations in LetsEncrypt cluster issuers Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants