Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unclear login rejection message #2658

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

andreas-kupries
Copy link
Contributor

fix #2630

@andreas-kupries andreas-kupries added kind/bug Something isn't working area/api API related requests and bugs labels Oct 16, 2023
@andreas-kupries andreas-kupries added this to the v1.11.0 milestone Oct 16, 2023
@andreas-kupries andreas-kupries self-assigned this Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
internal/api/v1/middleware/authentication.go 56.79% <50.00%> (+0.26%) ⬆️

... and 11 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@andreas-kupries andreas-kupries marked this pull request as ready for review October 16, 2023 11:41
@andreas-kupries andreas-kupries requested a review from a team as a code owner October 16, 2023 11:41
@andreas-kupries andreas-kupries merged commit 684653d into main Oct 16, 2023
16 checks passed
@andreas-kupries andreas-kupries deleted the 2630-login-message branch October 16, 2023 13:50
@mmartin24
Copy link
Contributor

Checked in

✔️  Epinio Environment
Platform: k3s
Kubernetes Version: v1.26.10+k3s2
Epinio Server Version: v1.11.0-rc1
Epinio Client Version: v1.11.0-rc1
OIDC enabled: true

Expected message ok after entering wrong user:

➜  epinio git:(main) ✗ epinio login -u wrong-user https://epinio.192.168.16.3.omg.howdoi.website

🚢  Login to your Epinio cluster [https://epinio.192.168.16.3.omg.howdoi.website]
Password: 

⚠️  Certificate signed by unknown authority

|     KEY     |      VALUE       |
|-------------|------------------|
| Issuer Name | CN=epinio-ca     |
| Common Name | epinio-ca        |
| Expiry      | 2024-February-21 |

Do you want to trust it (y/n): y

✔️  Trusting certificate for address https://epinio.192.168.16.3.omg.howdoi.website...

❌  error verifying credentials: error while connecting to the Epinio server: user not found

@andreas-kupries andreas-kupries changed the title fix login rejection message to be more clear about possible causes Fixed login rejection message to be more clear about possible causes Nov 29, 2023
@enrichman enrichman changed the title Fixed login rejection message to be more clear about possible causes Fixed unclear login rejection message Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api API related requests and bugs kind/bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Misleading error message when login with wrong user
3 participants