Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated staging scripts removed hardcoded -process-type=web #2674

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

enrichman
Copy link
Member

This PR updates the staging scripts removing the hardcoded -process-type=web flag.

This means that we are not forced to use a Procfile specifying the web process to run, but we are relying on the default detected by the Buildpacks.

We can still provide a Procfile to customize it, if needed.

@enrichman enrichman added the kind/enhancement New feature or request label Oct 19, 2023
@enrichman enrichman added this to the v1.11.0 milestone Oct 19, 2023
@enrichman enrichman self-assigned this Oct 19, 2023
@enrichman enrichman requested a review from a team as a code owner October 19, 2023 09:20
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

see 22 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@enrichman enrichman merged commit fc51435 into main Oct 19, 2023
17 checks passed
@enrichman enrichman deleted the remove-hardcoded-launch-process branch October 19, 2023 12:21
@mmartin24
Copy link
Contributor

Checked and working with:

✔️  Epinio Environment
Platform: k3s
Kubernetes Version: v1.26.10+k3s2
Epinio Server Version: v1.11.0-rc1
Epinio Client Version: v1.11.0-rc1
OIDC enabled: true

Golang app directory has no Proc file:

➜  golang-sample-app git:(main) ✗ ls    
go.mod  main.go

Push the app and check is successful:

epinio push --name testapp-go-ep-repo -p /home/mmartin/suse/epinio-repos/epinio/assets/golang-sample-app/ --env='BP_KEEP_FILES=static/*'

# Output 
✔️  App is online.
Name: testapp-go-ep-repo
Namespace: workspace
Builder Image: 
Routes: 
1: https://testapp-go-ep-repo.192.168.16.3.omg.howdoi.website

@mmartin24
Copy link
Contributor

Adding one more observation after this test.
When trying the 12factor app example (https://github.com/epinio/example-12factor) removing its Procfile failed.
Error:

Deploying application ...
.....................................................................................................................................................................................
❌  error pushing app to server: release example12fac-02f2aad20a8b61a5578c21278a4766ed9478745b failed, and has been uninstalled due to atomic being set: context deadline exceeded

To reproduce:

# Clone repo and cd into it
git clone https://github.com/epinio/example-12factor.git
cd example-12factor

# Remove the Procfile

# Push app from path
➜ example-12factor git:(main) ✗  epinio push -n example12factor-without-procfile -p /home/epinio-repos/example-12factor

Looking at the Procfile I see:

web: bundle exec ruby web.rb -p $PORT -o 0.0.0.0

@enrichman I understand this is expected given this is different type of Procfile here, right?

@mmartin24
Copy link
Contributor

epinio push -n example12factor-without-procfile -p /home/epinio-repos/example-12factor

Clarified offline. In this case Procfile is needed

@andreas-kupries andreas-kupries changed the title Updated staging scripts Updated staging scripts, removed hardcoded -process-type=web Nov 29, 2023
@enrichman enrichman changed the title Updated staging scripts, removed hardcoded -process-type=web Updated staging scripts removing the need for the Procfile Dec 1, 2023
@enrichman enrichman changed the title Updated staging scripts removing the need for the Procfile Updated staging scripts removed hardcoded -process-type=web Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants