Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import drop of epinio-ui(-tls) cert and secret. #2693

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

andreas-kupries
Copy link
Contributor

No description provided.

@andreas-kupries andreas-kupries added the kind/chore Excluded from release notes. Tech dept to be addressed label Nov 14, 2023
@andreas-kupries andreas-kupries added this to the v1.11.0 milestone Nov 14, 2023
@andreas-kupries andreas-kupries self-assigned this Nov 14, 2023
@andreas-kupries andreas-kupries marked this pull request as ready for review November 14, 2023 11:21
@andreas-kupries andreas-kupries requested a review from a team as a code owner November 14, 2023 11:21
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (17e99da) 67.15% compared to head (8947409) 66.38%.
Report is 4 commits behind head on main.

Files Patch % Lines
internal/cli/cmd/exportregistry.go 42.85% 7 Missing and 1 partial ⚠️
internal/cli/cmd/version.go 50.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2693      +/-   ##
==========================================
- Coverage   67.15%   66.38%   -0.78%     
==========================================
  Files         210      211       +1     
  Lines       18486    18496      +10     
==========================================
- Hits        12415    12279     -136     
- Misses       4998     5104     +106     
- Partials     1073     1113      +40     
Flag Coverage Δ
acceptance-api 46.22% <50.00%> (-0.65%) ⬇️
acceptance-apps 36.29% <50.00%> (-0.22%) ⬇️
acceptance-cli 62.35% <50.00%> (-0.68%) ⬇️
unittests 14.45% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreas-kupries andreas-kupries merged commit d53b1fe into main Nov 14, 2023
17 checks passed
@andreas-kupries andreas-kupries deleted the drop-epinio-ui-tls branch November 14, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Excluded from release notes. Tech dept to be addressed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants