Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: expose appChart url through values #440

Closed
riqueps opened this issue Jun 19, 2023 · 1 comment · Fixed by #458
Closed

Feature Request: expose appChart url through values #440

riqueps opened this issue Jun 19, 2023 · 1 comment · Fixed by #458
Assignees
Labels
kind/enhancement New feature or request
Milestone

Comments

@riqueps
Copy link

riqueps commented Jun 19, 2023

Is your feature request related to a problem?

For complex environments a custom appChart may be necessary, eg: add custom ingress annotation, select the ingress controller based on the domain, etc...

For now we are able to create a new appChart and turn it default, but this is a local setting, as documented here.

So, by mapping the appChart helm url through values, epinio admins can setup a default system wide custom appChart

File: default-app-chart.yaml

Paramter: helmChart: https://xxxx.xxx.xx

Solution you'd like

Map it to Values.yaml file, eg:

appChart:
  url: https://github.com/epinio/helm-charts/releases/download/epinio-application-0.1.26/epinio-application-0.1.26.tgz

Alternatives you've considered

For now we are manually editing the standard appChart

Anything else?

No response

@enrichman enrichman added this to the v1.9.0 milestone Jun 21, 2023
@enrichman
Copy link
Member

Hi @riqueps, it seems a nice and easy feature. We are going to schedule this for the next release. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants