Expose location of default AppChart tarball for configuration by operators

[andreas-kupries]

Imported chart work in epinio/helm-charts#458

Ticket Ref epinio/helm-charts#440

[codecov]

Codecov Report

Patch coverage: 91.95% and project coverage change: -0.05 ⚠️

Comparison is base (b2c8713) 65.63% compared to head (dc1067f) 65.59%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2431      +/-   ##
==========================================
- Coverage   65.63%   65.59%   -0.05%     
==========================================
  Files         185      185              
  Lines       15611    15523      -88     
==========================================
- Hits        10247    10183      -64     
+ Misses       4279     4266      -13     
+ Partials     1085     1074      -11     

Flag	Coverage Δ
acceptance-api	48.68% <75.86%> (+0.39%)	⬆️
acceptance-apps	38.01% <79.31%> (+0.15%)	⬆️
acceptance-cli	62.15% <90.80%> (-0.03%)	⬇️
unittests	11.97% <59.77%> (+0.81%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
internal/cli/usercmd/client.go	68.42% <ø> (ø)
internal/helm/helm.go	77.93% <79.16%> (-2.02%)	⬇️
pkg/api/core/v1/client/apps.go	50.73% <93.54%> (-0.24%)	⬇️
internal/cli/usercmd/service.go	74.71% <100.00%> (ø)
pkg/api/core/v1/client/envs.go	100.00% <100.00%> (+33.33%)	⬆️
pkg/api/core/v1/client/http.go	49.15% <100.00%> (-2.88%)	⬇️
pkg/api/core/v1/client/namespaces.go	100.00% <100.00%> (+21.81%)	⬆️
pkg/api/core/v1/client/services.go	89.61% <100.00%> (+10.09%)	⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[thehejik]

Verified in epinio v1.9.0-rc4 as working.

When installing or upgrading Epinio via helm the user/operator can specify location of his custom app chart which then will be used as standard app chart.

Tested as follows by providing --set appChart.default=https://github.com/epinio/helm-charts/releases/download/epinio-application-0.1.23/epinio-application-0.1.23.tgz

Where the default one in RC4 is https://github.com/epinio/helm-charts/releases/download/epinio-application-0.1.26/epinio-application-0.1.26.tgz

helm upgrade --install epinio --namespace epinio epinio/epinio --set global.domain=10.100.103.16.nip.io --create-namespace --devel --set appChart.default=https://github.com/epinio/helm-charts/releases/download/epinio-application-0.1.23/epinio-application-0.1.23.tgz

Then verified the app chart location as Helm Chart value has been changed:

epinio app chart show standard

🚢  Show application chart details
Name: standard

🚢  Details:
|       KEY       |                                                      VALUE                                                      |
|-----------------|-----------------------------------------------------------------------------------------------------------------|
| Name            | standard                                                                                                        |
| Created         | 2023-07-18 14:32:10 +0000 UTC                                                                                   |
| Short           | Epinio standard deployment                                                                                      |
| Description     | Epinio standard support chart                                                                                   |
|                 | for application deployment                                                                                      |
| Helm Repository |                                                                                                                 |
| Helm Chart      | https://github.com/epinio/helm-charts/releases/download/epinio-application-0.1.23/epinio-application-0.1.23.tgz |

🚢  Settings
|       KEY        |  TYPE   | ALLOWED VALUES |
|------------------|---------|----------------|
| appListeningPort | integer | [0 ... +inf]   |

✔️  Ok

I verified that the Helm Chart URI is changed also here:

$ k get appcharts.application.epinio.io -o yaml -n epinio standard
...
spec:
  description: Epinio standard support chart for application deployment
  helmChart: https://github.com/epinio/helm-charts/releases/download/epinio-application-0.1.23/epinio-application-0.1.23.tgz
...