Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularise observation model #133

Closed
6 tasks done
seabbs opened this issue Jul 22, 2022 · 1 comment · Fixed by #137
Closed
6 tasks done

Modularise observation model #133

seabbs opened this issue Jul 22, 2022 · 1 comment · Fixed by #137
Assignees
Labels
enhancement New feature or request high-priority

Comments

@seabbs
Copy link
Collaborator

seabbs commented Jul 22, 2022

In trying to fix merge issues with #106 I found that it was quite difficult due to the amount of repeated code across functions. To make ongoing development easier I think we should look at making the observation model parts of the code more modular.

This includes:

  • Combining the logit hazards
  • Making a true obs function with vectorised and non-vectorised and rng options (precisely how to do this without code duplication is a little tricky)
  • Share more code across generated quantities and the main likelihood
  • Make a function for producing nowcasts from same data format as used in the main likelihood
  • Make a function for producing posterior predictions from the same format as used in the main likelihood
  • A vectorised version of expected_obs() that can be reused across functions/use cases.
@seabbs seabbs added enhancement New feature or request high-priority labels Jul 22, 2022
@seabbs seabbs self-assigned this Jul 22, 2022
@seabbs
Copy link
Collaborator Author

seabbs commented Jul 30, 2022

All done in #138

@seabbs seabbs closed this as completed Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high-priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant