New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 347: Add enw_one_hot_encode_feature helper + example using parametric and nonparametric reporting together. #348
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report
@@ Coverage Diff @@
## main #348 +/- ##
==========================================
- Coverage 96.93% 96.84% -0.10%
==========================================
Files 15 15
Lines 1862 1871 +9
==========================================
+ Hits 1805 1812 +7
- Misses 57 59 +2
|
… variables seems excessive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Self-review] This PR adds single example that showcases how to mix the parametric and non-parametric models. It also adds a feature and a helper function that is useful when building these models (I was surprised this helper wasn't more readily available in other packages tbh).
Given its low impact on the rest of the code base I am minded to merge this now as all looks as expected and then resolve any potentially issues prior to a new release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[SELF-REVIEW] Final checks prior to merging.
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 42310d6 is merged into main:
|
Description
This PR closes #347.
enw_one_hot_encode_feature()
for one hot encoding variables and binding them into the original data. This is useful when users want to include parts of variables in their models as binary indicators - for example giving a specific delay its own effect.Checklist
NEWS.md
and theDESCRIPTION
.