New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 367: Add system to keep citation files in sync with DESCRIPTION #369
Conversation
0a187b7
to
2c31019
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great James thanks. Could you put a new news item in referring to this PR and also add yourself as a contributor if you are happy to do so?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
=======================================
Coverage 96.85% 96.85%
=======================================
Files 15 15
Lines 1875 1875
=======================================
Hits 1816 1816
Misses 59 59 ☔ View full report in Codecov by Sentry. |
235b1ff
to
bf66892
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice this looks great. The only remaining thing to do is to update the README to include this but I think we should do that once its on main
via the CI workflow vs here.
Are you happy for me to go ahead and merge this @jamesmbaazam? |
Yes, please go ahead. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if ef6c955 is merged into main:
|
Description
This PR closes #367.
In this PR, I set up the
inst/CITATION
file to pull relevant fields from the DESCRIPTION file. I also add a workflow to generate acitation.cff
whenever relevant fields in CITATION and DESCRIPTION files change. This way, the package always has up-to-date citation information, which can be copied from the citation panel on the package landing page or by runningcitation(epinowcast)
.Checklist
NEWS.md
and theDESCRIPTION
.