Feature optional profiling include paths #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #54 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 13 13
Lines 655 685 +30
=====================================
- Misses 655 685 +30
Continue to review full report at Codecov.
|
adrian-lison
commented
May 10, 2022
seabbs
requested changes
May 16, 2022
|
Thanks for reviewing @seabbs :) I have improved the formatting as suggested. Will consider proposing it to |
|
/document |
seabbs
previously approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the optional profiling also to .stan files in the include paths, and moves the whole functionality to a separate function which is called by
enw_modelif required. All manipulated .stan files with profiling statements removed are stored in the same temporary directory.Implementation details: By using the same folder structure in the temporary directory as in the original include paths, the relative include paths still apply and the model code is not further touched aside from removing the profiling. This should make the approach very robust. Also, the names of the main model and the included file paths are now directly mirrored, so that warnings or errors from stanc stating a filepath allow the user to pinpoint the corresponding original .stan file.
This PR also adds more detailed profiling statements to the likelihood parts of the model.