Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the expectation random walk to use the cumulative sum formulation #98

Closed
Tracked by #92
seabbs opened this issue Jul 5, 2022 · 1 comment · Fixed by #103
Closed
Tracked by #92

Update the expectation random walk to use the cumulative sum formulation #98

seabbs opened this issue Jul 5, 2022 · 1 comment · Fixed by #103
Labels
enhancement New feature or request high-priority

Comments

@seabbs
Copy link
Collaborator

seabbs commented Jul 5, 2022

It is more efficient to encode random walks using a cumulative sum formulation. There should be no downsides to this change.

This section of the code

https://github.com/epiforecasts/epinowcast/blob/38ab91013fe105935c11bf2f9c199a2fbf0c2110/inst/stan/epinowcast.stan#L131

needs to be updated to use the same approach as seen here.

https://github.com/epiforecasts/epinowcast/blob/a48ae0a9ee0652d8b1ffbf6220484ec9c1de2114/inst/stan/epinowcast.stan#L141
@seabbs seabbs added enhancement New feature or request high-priority labels Jul 5, 2022
This was referenced Jul 5, 2022
Closed
Closed
Merged
@seabbs
Copy link
Collaborator Author

seabbs commented Jul 7, 2022

Done in #103

@seabbs seabbs closed this as completed Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request high-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature cumulative sum expectation epinowcast/epinowcast
1 participant
@seabbs