add Serializable to AvroCoder and AvroSchemaRegistryClient #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextdude
requested changes
Nov 30, 2021
There was a problem hiding this comment.
I think the only change that may be required here are the build.sbt changes. The environment variable stuff definitely isn't required as there is already a built-in solution. Regarding the latest version change, can you show the error and location that requires this fix so I can evaluate if there's a better option? Thanks.
src/main/scala/io/epiphanous/flinkrunner/avro/ConfluentSchemaRegistryClient.scala
Outdated
Show resolved
Hide resolved
src/main/scala/io/epiphanous/flinkrunner/avro/ConfluentSchemaRegistryClient.scala
Outdated
Show resolved
Hide resolved
src/main/scala/io/epiphanous/flinkrunner/avro/ConfluentSchemaRegistryContext.scala
Outdated
Show resolved
Hide resolved
src/main/scala/io/epiphanous/flinkrunner/model/FlinkConfig.scala
Outdated
Show resolved
Hide resolved
src/main/scala/io/epiphanous/flinkrunner/model/SinkConfig.scala
Outdated
Show resolved
Hide resolved
src/main/scala/io/epiphanous/flinkrunner/model/SinkConfig.scala
Outdated
Show resolved
Hide resolved
src/main/scala/io/epiphanous/flinkrunner/model/SinkConfig.scala
Outdated
Show resolved
Hide resolved
src/main/scala/io/epiphanous/flinkrunner/model/SourceConfig.scala
Outdated
Show resolved
Hide resolved
nextdude
requested changes
Dec 1, 2021
removed `sbt assembly` from plugins.sbt
nextdude
approved these changes
Dec 1, 2021
nextdude
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.