New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Iceberg support #68
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextdude
approved these changes
Apr 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flink-connector-aws-kinesis-streams
SourceConfig
andSinkConfig
to inherit from a commonSourceOrSinkConfig
trait to enable common configuration processing across source and sink configs.SinkConfig.get*Sink()
methods to returnUnit
instead ofDataStream[E]
and rename them toadd*Sink()
. This simplifies their usage since their return value was never used and not all sinks returnDataStreams
(like Cassandra and Iceberg) as easily as some other Flink sink apis.EmbeddedRowType
trait to support convertingFlinkEvent
instances to Row objects for use with Row type sinks, like IcebergTableStreamJob
job class to support jobs that sink to Row type sinks, like Iceberg.