adding a reg type prop to Kinesis source #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextdude-mdsol
suggested changes
Mar 16, 2023
There was a problem hiding this comment.
Do you know if this property solves your problem with running kinesis? It seems pretty specialized. My question is why add this property, while not adding other EFO properties, or other properties in general? It is possible to configure this without adding this specific property. Also, we should have some tests to prove the configuration actually sets the value properly.
| @@ -142,9 +142,16 @@ case class KinesisSourceConfig[ADT <: FlinkEvent]( | |||
| config.getStringOpt | |||
| ).getOrElse(s"${config.jobName}.$name") | |||
|
|
|||
| val efoRegistrationType : String = getFromEither( | |||
| pfx(), | |||
| Seq("efo.registration.type", "flink.stream.efo.registration.type", EFO_REGISTRATION_TYPE), | |||
There was a problem hiding this comment.
Isn't EFO_REGISTRATION_TYPE = "flink.stream.efo.regionstration.type"? Don't need both.
There was a problem hiding this comment.
EFO_REGISTRATION_TYPE = "flink.stream.efo.registration"
|
We handled this a different way. Closing without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a registration type property to the Kinesis source, with Lazy as default as per flink Kinesis implementation