Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated deps for routing-controllers 0.10.0 #127

Merged
merged 2 commits into from
Dec 31, 2022

Conversation

leonardlin
Copy link
Contributor

updated peer dependency for routing-controllers 0.10.0

See also: #120

@leonardlin
Copy link
Contributor Author

@epiphone it seems that routing-controllers has awaken again and has made urgent dependency updates.

I created a PR to go along the newest version, would you mind reviewing the PR?

@leonardlin
Copy link
Contributor Author

Hi @epiphone could you take a look at this PR? routing-controller has to come to life again and this PR is an update to match the new routing-controller version

Copy link
Owner

@epiphone epiphone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! I enabled the CI pipeline here, please make sure all the tests pass.

src/generateSpec.ts Outdated Show resolved Hide resolved
__tests__/fixtures/spec.json Show resolved Hide resolved
@leonardlin
Copy link
Contributor Author

@epiphone hope the updated PR is ok now.
linting and tests pass locally.

@codecov
Copy link

codecov bot commented Dec 31, 2022

Codecov Report

Merging #127 (c65915f) into master (7c5bc3e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files           4        4           
  Lines         226      227    +1     
  Branches       72       73    +1     
=======================================
+ Hits          225      226    +1     
  Misses          1        1           
Impacted Files Coverage Δ
src/generateSpec.ts 100.00% <ø> (ø)
src/decorators.ts 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@epiphone epiphone merged commit 9bf82ed into epiphone:master Dec 31, 2022
@epiphone
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants