Use pytest
#48
Closed
Use pytest
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- release.py can now update new `epispot/__init__.py`
- Adds classifiers and project URLS to both `setup.py` and `setup-nightly.py`
- Removes unnecessary testing suites (`test_cov.py`)
- Changes `epispot.__version__` to `epispot.version`, meaning it is now accessible globally and will show up on pdoc
- Updates `bin/epispot` to use new `epispot.version` to give version info
Replaces with:
```python
except ImportError:
# foo
```
Creates README.md to explain testing with `pytest` See `test_x.py` as an example of a properly-configured test.
All `epispot.pre` modules are now compatible with pytest through `tests/pytest/test_sir-variants.py` - SIR - SEIR - SIRD - SIHRD
Tests - Recurrent models - Starting state - Critical compartment - Triage
Tests - Plotting - Fitters (none currently)
Removes
- epi.fitters
- grad_des
- tree_search (experimental)
- epi.plots
- compare
Changes most foo/* paths to foo/
- Fixes code coverage issue due to warnings being included in code coverage reporting - Changes sanity check to check *only* for missing version and source information
- Changes `setup-nightly` package data
* Removes existing epispot installation in testing workflows Solves installation issue * Bypasses Python `proceed? (y/n)` prompt when uninstalling epispot Fixes error from previous commit * Runs `pytest` as module to import epispot from `Namespace` * Removes epispot from `bin/requirements.txt` Per @Quantalabs request
quantum9Innovation
added
doc 📜
github-actions
bot
added
src
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
- Coverage 97.44% 88.42% -9.03%
==========================================
Files 6 7 +1
Lines 470 432 -38
==========================================
- Hits 458 382 -76
- Misses 12 50 +38
Continue to review full report at Codecov.
|
|
Code coverage failed due to not testing the CLI, which will be fixed in a later PR. For now, code coverage is essentially passing.
|
|
This pull request introduces 1 alert and fixes 1 when merging 0fc625a into 99e1f24 - view on LGTM.com new alerts:
fixed alerts:
|
|
We are now ready for review, pinging @Quantalabs |
Quantalabs
requested changes
May 10, 2021
|
This is still high priority |
|
After review, we're splitting up the PR into multiple PRs that will be merged in a certain order specified on this PR and the Management project |
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up
pytestas main testing frameworkAfter PR #46, solves issue #47
New Feature
Transforms old tests to use
pytestas the main testing framework.pytestallows forassert-based testing and boundsIt also adds GitHub CODEOWNERS
Known Issues
Fixes #47 "Getting started with pytest"
Code Breakdown
$ python -m pytestcommandexceptwithexcept ImportErrorepispotdue topip install -r bin/requirements.txtcommand in workflows which installs epispot from PyPI instead of from the sourcehelp()commands)__from metadata variable names to make them globally accessible# pragma: no coveron soon-to-be deprecated functionstests/directory cleanpytest__init__.pyAdditional Notes
There's a lot going on in this PR and it may need to be broken up into multiple PRs.
For now, it will be created as a draft PR just because of the sheer scale of the PR.
Additionally, before moving into merge stage, all merge conflicts should be resolved and all basic checks (build and code coverage) should pass. After we enter the merge stage, reviewers should analyze code for compatibility issues and other code quality-related alerts will be dealt with if necessary.
Closes #47