Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Dependabot and configure related settings #81

Closed
Tracked by #79
quantum9Innovation opened this issue Jul 1, 2021 · 4 comments · Fixed by #86
Closed
Tracked by #79

Install Dependabot and configure related settings #81

quantum9Innovation opened this issue Jul 1, 2021 · 4 comments · Fixed by #86
Labels
good first issue 👍 Good for newcomers help wanted 🚁 Extra attention is needed
Milestone

Comments

@quantum9Innovation
Copy link
Member

quantum9Innovation commented Jul 1, 2021

This issue is part of a series of tasks listed in #81.

@Quantalabs
Copy link
Member

@quantum9Innovation will start on #80, and I'll start work on this issue

/claim

Quantalabs added a commit that referenced this issue Jul 1, 2021
Create dependabot.yml
@Quantalabs
Copy link
Member

Work has started on branch patch-81

@quantum9Innovation
Copy link
Member Author

Use:

git branch -m patch-#81 patch-81
git fetch origin
git branch -u origin/patch-81 patch-81

to rename your local branch. Always use patch-{issue #} instead of patch-#{issue #} when creating branch names.

@quantum9Innovation quantum9Innovation moved this from To do to In progress in Maintenance v2 Jul 1, 2021
@quantum9Innovation
Copy link
Member Author

The problem right now is that we need some way to configure Travis CI to run tests with the latest dependencies that we support. That way, when dependabot updates our dependencies, we can run checks to confirm that our package is compatible with those updates.

$ pip install -r requirements-dev.txt has already failed on Travis CI. This is because pip installs all the dependencies simultaneously. And since plotly, one of the dependencies, does not correctly list pandas as a sub-dependency, we must add pandas to the requirements-dev.txt file. However, when pip simultaneously installs all the dependencies, pandas is not installed before plotly and this raises an error.

At least that's what we know so far. @Quantalabs any ideas?

@quantum9Innovation quantum9Innovation added good first issue 👍 Good for newcomers help wanted 🚁 Extra attention is needed labels Jul 1, 2021
quantum9Innovation added a commit that referenced this issue Jul 1, 2021
Add Dependabot config and modify Travis CI and requirement files to
apply Dependabot version bumps. Requirements files have now been moved
to a new directory which contains a Travis build script to install the
requirements to a new virtual environment.

Changelist:
- Add .github/dependabot.yml config
- Modify Travis CI to install LaTeX and pandas first, then use build
script in .travis.yml
- Add build script in requirements/build-travis.sh
- Move requirements files to requirements/ directory

Additional Notes:
Fixes (minor):
Fix "Install Dependabot and configure related settings" (#81)
@Quantalabs Quantalabs mentioned this issue Jul 1, 2021
@Quantalabs Quantalabs added this to the Dependabot milestone Jul 1, 2021
Maintenance v2 automation moved this from In progress to Done Jul 1, 2021
quantum9Innovation added a commit that referenced this issue Jul 1, 2021
* Start work on #81

Create dependabot.yml

* Add extra configuration for dependabot

Add extra configuratorion for dependabot including auto-assignees, auto prefix commit messages, and PR labels.

* Add extra config

* Remove branch seperator

Co-authored-by: q9i <46249765+quantum9Innovation@users.noreply.github.com>
Quantalabs added a commit that referenced this issue Jul 1, 2021
* Start work on #81

Create dependabot.yml

* Add extra configuration for dependabot

Add extra configuratorion for dependabot including auto-assignees, auto prefix commit messages, and PR labels.

* Add extra config

* Remove branch seperator

Co-authored-by: q9i <46249765+quantum9Innovation@users.noreply.github.com>
Quantalabs added a commit that referenced this issue Jul 1, 2021
* Patch #81 (#86)

* Start work on #81

Create dependabot.yml

* Add extra configuration for dependabot

Add extra configuratorion for dependabot including auto-assignees, auto prefix commit messages, and PR labels.

* Add extra config

* Remove branch seperator

Co-authored-by: q9i <46249765+quantum9Innovation@users.noreply.github.com>

* Use a bash script for travis CI

* Fix travis build

* Debug travis CI

* Update `requirements/` README

* Apply suggestions from code review

Apply suggestions from code review suggested by @quantum9Innovation

Co-authored-by: q9i <46249765+quantum9Innovation@users.noreply.github.com>

Co-authored-by: q9i <46249765+quantum9Innovation@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue 👍 Good for newcomers help wanted 🚁 Extra attention is needed
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants