Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Travis CI → GitHub Actions #93

Merged
merged 7 commits into from Jul 20, 2021
Merged

Conversation

quantum9Innovation
Copy link
Member

Bye Bye Travis


Known Issues

This PR fixes a major issue with Travis CI where paid credits are being used to fund OSS builds. The error message on Travis CI reads:

Builds have been temporarily disabled for public repositories due to a negative credit balance. Please go to the Plan page to
replenish your credit balance or alter your Consume paid credits for OSS setting.

Essentially, this means that Travis CI will no longer run builds in the epispot organization. To make matters worse, the only reason we switched to Travis CI was due to the CodeCov bash uploader security breach. Since Travis CI was isolated from our GitHub repository and each build had no tokens unique to our repository, it was a safe alternative to GitHub Actions. However, if Travis CI continues not to run, it has the potential to create more security vulnerabilities than it fixes. For that reason, we are making the switch back from Travis CI to GitHub Actions.

Code Breakdown

  • .github/workflows
    • Create build.yml as a replacement for /.travis.yml
  • requirements/
    • Update README to acknowledge pre-requirements
    • Add pre-requirements.txt for requirements that need to be installed first
  • scripts/
    • Update README.md to acknowledge renamed runner/ directory
    • Rename travis/ directory to runner/ and modify build script to be compatible with new requirements
  • Remove .travis.yml

Additional Notes

As a CODEOWNER, @Quantalabs will lead the review process. We will need to make sure that this script is completely airtight before merging.

Quantalabs and others added 6 commits July 20, 2021 15:01
Steps have been renamed to resemble the old Travis CI config and a few
mistakes have been corrected with the script.

Changelist:
- Redo .github/workflows/build.yml
- Rename scripts/travis to scripts/runner
- Detail above renaming in scripts/README.md
Modify requirements files to list pre-requirements and then tell runner
script to install these first and everything else after.

Changelist:
- Change scripts/runner/build.sh to use pre-requirements.txt
- requirements/
    - Create pre-requirements.txt
    - Modify README.md to acknowledge above creation
@quantum9Innovation quantum9Innovation added bug ⚠️ Something isn't working unsupported ⛔ Currently unsupported feature high-priority 🔼 This is important labels Jul 20, 2021
@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #93 (9b438a3) into master (fbdf88e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   90.15%   90.15%           
=======================================
  Files           9        9           
  Lines         508      508           
=======================================
  Hits          458      458           
  Misses         50       50           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbdf88e...9b438a3. Read the comment docs.

Copy link
Member

@Quantalabs Quantalabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@quantum9Innovation quantum9Innovation merged commit 0c39f42 into master Jul 20, 2021
@quantum9Innovation quantum9Innovation deleted the bye-bye-travis branch July 20, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ⚠️ Something isn't working high-priority 🔼 This is important unsupported ⛔ Currently unsupported feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants