Revise plotting page #76
Conversation
|
@chartgerink thanks for the updates, it's looking in better shape and seems clearer. I've left a few comments in the diff and I'm happy to discuss next steps. |
|
Thanks @joshwlambert - sorry I haven't gotten around to this. I'm unable to get to it for the next two weeks but have it planned for the (early) week of the 18th. |
|
@chartgerink no problem. No urgent reason to merge this from my side so happy to discuss whenever you're free. |
Co-authored-by: Joshua Lambert <joshua.lambert@lshtm.ac.uk>
|
Thanks @joshwlambert - I resolved all your suggestions and reinvited your review. Happy to discuss this synchronously as well to ensure alignment 馃槉 |
There was a problem hiding this comment.
Looks good to me @chartgerink. Thanks for your work on this.
It would be good to get @Bisaloo & @TimTaylor input as they input to the internal discussion that led to this chapter, but from my side happy to merge when you're ready.
|
Thanks @joshwlambert 馃檹 This branch is merging into your branch, so I will be sure to invite them over on that PR #44. |
This PR against the plotting branch is an attempt to consolidate some of the discussions had in PR #44. I am doing this first to get sign-off from the original contributor as this is quite the change.
@joshwlambert - I wanted to be sure to give you a first read and the opportunity to say whether this is okay with you (or not). I rewrote the page quite a bit without your approval, so feel free to decline. I wanted to ensure I could pull this along the finish line in case you approve of these changes. 馃槉