Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tracking pkgdown/ #56

Closed
pratikunterwegs opened this issue Jul 13, 2023 · 3 comments · Fixed by #57
Closed

Allow tracking pkgdown/ #56

pratikunterwegs opened this issue Jul 13, 2023 · 3 comments · Fixed by #57

Comments

@pratikunterwegs
Copy link
Collaborator

This issue is to flag that we may want to add the pkgdown/ directory to tracking in the future.

This folder can contain important files we want to commit. Do you have any issues that lead you to add it here?

Originally posted by @Bisaloo in #54 (comment)

@Bisaloo
Copy link
Member

Bisaloo commented Jul 13, 2023

If you don't want to have the logos, you can delete them. They will be regenerated by pkgdown as necessary (as they are now). But the pkgdown/ folder should not be .gitignored. It is a valid pkgdown config folder that can contain valuable information (example in pkgdown itself: https://github.com/r-lib/pkgdown/tree/main/pkgdown)

@pratikunterwegs
Copy link
Collaborator Author

The example contains mostly the pkgdown YAML, which we already include in our top-level directory (across packages, based on {packagetemplate}) - does the locations of this file also need to be changed?

@Bisaloo
Copy link
Member

Bisaloo commented Jul 17, 2023

Both locations are valid so no need to change it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants