-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial fully functioning package #11
Conversation
Thanks @adamkucharski and @Bisaloo for your input - I've made a few changes to sort the technical issues, but the potential issue with the CFR correctness remains. I'm not able to determine where any error might be as this is primarily an adaptation of Tim's code. Happy to add more tests for algorithmic correctness if these could be suggested, and that might help tackle the issue. |
Co-authored-by: Adam Kucharski <adam.kucharski@lshtm.ac.uk>
Refreshing this review thread so we can merge this added functionality into |
Co-authored-by: Adam Kucharski <adam.kucharski@lshtm.ac.uk>
This PR is from a branch off
tim
(by @thimotei), and makes these changes over that branch, and overmain
:.Rmd
README,static_cfr
) to return named vectors rather than dataframes,format_cfr_neatly
to work with named vectors where changed,epiparameter
,reshape2
, andlubridate
direct dependencies;epiparameter
is now suggested, anddata.table
is added as more useful thanreshape2
andlubridate
while still reducing one dependency,rolling_cfr()
and new plotting function.