Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing packages to renv #92

Merged
merged 3 commits into from
May 29, 2023
Merged

Add missing packages to renv #92

merged 3 commits into from
May 29, 2023

Conversation

joshwlambert
Copy link
Member

This PR closes #90.

I have added the packages used in the transmissibility rmd documents as well as {episoap} to the renv::use() call in the skeleton document.

@joshwlambert joshwlambert requested a review from Bisaloo May 25, 2023 13:54
Copy link
Member

@Bisaloo Bisaloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the report & PR!

I would like to avoid to include packages that are not directly used in the report in the citation. The underlying cause of this issue is that renv::dependencies() is used to identify dependencies and it will by default look at all files recursively in the current working directory. The best fix would be to find a way to just look at the main files and actually used child documents.

@Bisaloo
Copy link
Member

Bisaloo commented May 25, 2023

The proper fix seems to be using grateful::cite_packages(output = "paragraph", out.dir = ".", pkgs = "Session") to only cite packages actually loaded in the session.

…im packages from skeleton renv::use(), relates #90
@joshwlambert
Copy link
Member Author

@Bisaloo thanks for the fix. I've tested it and it seems to work well. I've made the update in the last commit.

@codecov-commenter
Copy link

Codecov Report

Merging #92 (f8b894a) into main (a913d79) will not change coverage.
The diff coverage is n/a.

❗ Current head f8b894a differs from pull request most recent head a676ae1. Consider uploading reports for the commit a676ae1 to get more accurate results

@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   73.91%   73.91%           
=======================================
  Files           4        4           
  Lines          23       23           
=======================================
  Hits           17       17           
  Misses          6        6           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Bisaloo
Copy link
Member

Bisaloo commented May 29, 2023

Thanks!

@Bisaloo Bisaloo merged commit 48408d6 into main May 29, 2023
7 checks passed
@Bisaloo Bisaloo deleted the fix_render branch May 29, 2023 08:08
Bisaloo added a commit that referenced this pull request May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report not rendering
3 participants