Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sim functions #168

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Refactor sim functions #168

merged 2 commits into from
Mar 21, 2024

Conversation

jpavlich
Copy link
Member

  • Changed age_mean_f to age in sim functions
  • Added validation in get_sim_n_seropositive that checks same number of rows for foi and sample_size_by_age

@jpavlich jpavlich requested a review from ntorresd March 18, 2024 23:41
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.37%. Comparing base (79e113a) to head (ce9b72a).

❗ Current head ce9b72a differs from pull request most recent head 1c9136d. Consider uploading reports for the commit 1c9136d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
+ Coverage   70.32%   70.37%   +0.05%     
==========================================
  Files          10       10              
  Lines        1776     1779       +3     
==========================================
+ Hits         1249     1252       +3     
  Misses        527      527              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpavlich
Copy link
Member Author

Fixes #151

@ntorresd ntorresd merged commit e4072c9 into main Mar 21, 2024
7 checks passed
@ntorresd ntorresd deleted the refactor-sim-functions branch March 21, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants