Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only publish required files #34

Merged
merged 2 commits into from Jan 5, 2021
Merged

Only publish required files #34

merged 2 commits into from Jan 5, 2021

Conversation

willfarrell
Copy link
Contributor

@willfarrell willfarrell commented Jan 1, 2021

.github,spec, and .eslintrc.yml are currently shipping with the node modules. This should remove them.

--edit --
Wasn't able to find it in the npm docs, will types be white listed like main?

Also just saw #8, a duplicate, but might be outdated now.

@coveralls
Copy link

coveralls commented Jan 1, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling df06274 on willfarrell:patch-1 into 6b45983 on epoberezkin:master.

@willfarrell willfarrell mentioned this pull request Jan 1, 2021
63 tasks
@epoberezkin
Copy link
Owner

Wasn't able to find it in the npm docs, will types be white listed like main?

I believe so - I’ll need to check after it’s released...

@epoberezkin
Copy link
Owner

https://docs.npmjs.com/cli/v6/configuring-npm/package-json#files

They don’t mention types here though - probably better to whitelist it

@willfarrell
Copy link
Contributor Author

done

@epoberezkin epoberezkin merged commit 102e2eb into epoberezkin:master Jan 5, 2021
@willfarrell willfarrell deleted the patch-1 branch January 5, 2021 15:32
@styfle
Copy link

styfle commented Apr 18, 2022

I just found the same issue and realized there is already a PR with the fix.

However, this was never published to npm. The last publish was 1.0.0 in December 2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants