Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test "isVisible() rendering bypass" Performance #80

Open
rsandor opened this issue Jun 28, 2014 · 2 comments
Open

Test "isVisible() rendering bypass" Performance #80

rsandor opened this issue Jun 28, 2014 · 2 comments

Comments

@rsandor
Copy link
Collaborator

rsandor commented Jun 28, 2014

As I was cutting jQuery out of the library (#62) I came across an interesting article on StackOverflow that lead me to this jsperf showing that depending on how you check visibility there can be some serious performance consequences.

Let's build a test on http://jsperf.com/ to see just how much performance you gain having to check for visibility each frame. Specifically we should test the following:

  1. Visible container rendering with check
  2. Visible container rendering without check
  3. Invisible container rendering with check
@rsandor rsandor mentioned this issue Jul 9, 2014
2 tasks
rsandor added a commit that referenced this issue Jul 9, 2014
Removed the method from the base class and all references from the source. Since we are no longer using the hack due to problems with the approach, we can close the performance test ticket (#80).
rsandor added a commit that referenced this issue Jul 9, 2014
@ghost
Copy link

ghost commented Jul 9, 2014

Apparently GitHub requires a certain style for closing multiple issues at once. Whoops!

@rsandor
Copy link
Collaborator Author

rsandor commented Jul 9, 2014

Oh weird, I didn't know that wouldn't work. Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant