Merge pull request #50 from eporsche/fix_transfer_vacation_entitlement

fix transfer of vacation entitlements
eporsche · Feb 9, 2023 · 622d67f · 622d67f
2 parents 63e141a + 55a2e96
commit 622d67f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/app/Actions/TransferVacationEntitlement.php b/app/Actions/TransferVacationEntitlement.php
@@ -21,7 +21,7 @@ public function transfer(User $employee, $vacationEntitlementId)
         $vacationEntitlementToBeTransferred = VacationEntitlement::findOrFail($vacationEntitlementId);
 
         //fetch a possible vacation entitlement candiate
-        $useExistingVacationEntitlement = VacationEntitlement::where('ends_at', $vacationEntitlementToBeTransferred->end_of_transfer_period)->first();
+        $useExistingVacationEntitlement = $employee->vacationEntitlements()->where('ends_at', $vacationEntitlementToBeTransferred->end_of_transfer_period)->first();
         if (!empty($useExistingVacationEntitlement)) {
             $vacationEntitlementToBeTransferred->transferVacationDays($useExistingVacationEntitlement, [
                 'days' => $useExistingVacationEntitlement->days->plus($vacationEntitlementToBeTransferred->daysTransferrable())